Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color changes and version update #679

Merged
merged 2 commits into from
Oct 19, 2023
Merged

color changes and version update #679

merged 2 commits into from
Oct 19, 2023

Conversation

shayan-roshan
Copy link
Collaborator

@shayan-roshan shayan-roshan commented Oct 18, 2023 •
edited
Loading

adresses #676 and #678

@cwolf10
Copy link
Collaborator

cwolf10 commented Oct 18, 2023

Hey @shayan-roshan, is there an issue that this PR is addressing?

@shayan-roshan
Copy link
Collaborator Author

@cwolf10
this PR adresses:
https://github.com/orgs/GSA/projects/45/views/8?pane=issue&itemId=41275181
https://github.com/orgs/GSA/projects/45/views/8?pane=issue&itemId=41276891

@cwolf10
Copy link
Collaborator

cwolf10 commented Oct 18, 2023

Gotcha, can you include links to #676 and #678 in the description? Partially for the review, but also in case someone is making changes to this code 6 months from now and wanting to make sure to not re-introduce a bug.

@cwolf10
Copy link
Collaborator

cwolf10 commented Oct 18, 2023

Also can you add a screenshot of the elements you fixed?

@shayan-roshan
Copy link
Collaborator Author

#676
before:
Screen Shot 2023-10-18 at 12 47 09 PM
after:
Screen Shot 2023-10-18 at 12 47 47 PM

#678
before:
Screen Shot 2023-10-18 at 12 48 59 PM
after:
Screen Shot 2023-10-18 at 12 49 18 PM

cwolf10
cwolf10 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@cwolf10 cwolf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shayan-roshan shayan-roshan merged commit b2aa3bf into master Oct 19, 2023
1 check passed
@shayan-roshan shayan-roshan deleted the base-lighter-colors branch October 19, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwolf10 cwolf10 cwolf10 approved these changes

@davereed davereed Awaiting requested review from davereed davereed is a code owner

@christyhermansen christyhermansen Awaiting requested review from christyhermansen christyhermansen is a code owner

@yerramshilpa yerramshilpa Awaiting requested review from yerramshilpa yerramshilpa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shayan-roshan @cwolf10