Fixes rspec tests that fail with a clean test db #112
Conversation
|
Resolves #59 |
spec/engines/search_engine_spec.rb
Outdated
| @@ -17,6 +17,9 @@ def parse_search_engine_response(_) | |||
| end | |||
|
|
|||
| describe SearchEngine do | |||
| before(:all) do | |||
| CachedSearchApiConnectionResponse = Struct.new(:response, :cache_namespace) | |||
There was a problem hiding this comment.
@HalahAb , I see the issue with this spec, but I don't think that redefining the struct in the spec is the best approach. I think a safer fix would be to move the struct definition to lib/cached_search_api_connection_response.rb, to ensure that that class is auto-loaded.
| @@ -0,0 +1,3 @@ | |||
| # :nocov: | |||
There was a problem hiding this comment.
@HalahAb , please add a spec for this instead of skipping code coverage.
There was a problem hiding this comment.
@MothOnMars, I added a test then had to remove it because that one line was still being seen as missing coverage. I couldn't figure out why and thought to remove it because it was only testing ruby struct functionality. I added the test back now, but it turns out it was the other struct definition in cached_search_api_connection.rb that was causing the coverage fail. I removed it and that seems to have fixed things.
| require 'spec_helper' | ||
|
|
||
| describe CachedSearchApiConnectionResponse do | ||
| let(:cached_response) { CachedSearchApiConnectionResponse.new(:response, :cache_name) } |
There was a problem hiding this comment.
please remove extra space: { CachedSearchApiConnectionResponse...
spec/models/image_search_spec.rb
Outdated
| before do | ||
| allow(affiliate).to receive(:search_engine).and_return(search_engine) | ||
| allow(affiliate).to receive(:has_no_social_image_feeds?).and_return false |
There was a problem hiding this comment.
Please remove extra space: and_return false
No description provided.