(WIP) Feature/config random order rspec #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalahAb
changed the title
MothOnMars
reviewed
Jul 9, 2018
| @@ -174,6 +178,10 @@ | |||
| end | |||
|
|
|||
| context 'when Google response contains empty results' do | |||
|
|
|||
| before { I18n.locale = :es } | |||
There was a problem hiding this comment.
@HalahAb , nothing in this test seems to require that the language be set to es...? I would expect that the only time these before and after lines are required would be for specs with a context like when the site locale is es.
There was a problem hiding this comment.
I think it was causing new cassettes files to be generated, because when ran in order the previous example didn't switch back to en and the original cassette was in es for this context. I think I was trying to avoid that, but I've added the modified cassettes now.
MothOnMars
reviewed
Jul 10, 2018
| @@ -68,7 +68,7 @@ | |||
| :published_at => DateTime.parse("2011-09-26 21:33:06"), | |||
| :guid => '80799 at www.whitehouse.gov', | |||
| :rss_feed_url_id => rss_feed_urls(:white_house_blog_url).id) | |||
| 15.times do |x| | |||
There was a problem hiding this comment.
I think this change is not necessary. See my comments in https://rrsoft.slack.com/archives/G8APZCEH3/p1531181738000177
…= es causing fails.
…id api key failure
…post_processor_spec.rb --seed 21615
|
Resolves #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.