-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Feature/config random order rspec #63
(WIP) Feature/config random order rspec #63
Conversation
@@ -174,6 +178,10 @@ | |||
end | |||
|
|||
context 'when Google response contains empty results' do | |||
|
|||
before { I18n.locale = :es } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HalahAb , nothing in this test seems to require that the language be set to es
...? I would expect that the only time these before
and after
lines are required would be for specs with a context like when the site locale is es
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was causing new cassettes files to be generated, because when ran in order the previous example didn't switch back to en and the original cassette was in es for this context. I think I was trying to avoid that, but I've added the modified cassettes now.
@@ -68,7 +68,7 @@ | |||
:published_at => DateTime.parse("2011-09-26 21:33:06"), | |||
:guid => '80799 at www.whitehouse.gov', | |||
:rss_feed_url_id => rss_feed_urls(:white_house_blog_url).id) | |||
15.times do |x| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is not necessary. See my comments in https://rrsoft.slack.com/archives/G8APZCEH3/p1531181738000177
…= es causing fails.
…id api key failure
…post_processor_spec.rb --seed 21615
Resolves #59 |
No description provided.