SRCH-2315 remove mobile-fu gem & related logic #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MothOnMars
force-pushed
the
mobile_fu_2315
branch
2 times, most recently
from
ad950a8
to
674e937
Compare
MothOnMars
changed the title
- replace custom "mobile" format with "html" - remove remaining "force_mobile_format" logic - remove deprecated parameters from permitted list - remove or update tests - remove or update VCR cassettes
MothOnMars
force-pushed
the
mobile_fu_2315
branch
from
674e937
to
dd57b19
Compare
MothOnMars
commented
Jun 11, 2021
Comment on lines
-143
to
+121
| it 'should serialize an error into JSON' do | ||
| expect(response.body).to match(/error/) | ||
| expect(response.body).to match(/#{I18n.translate :too_long}/) | ||
| it 'serializes an error into JSON' do | ||
| parsed_response = JSON.parse(response.body) | ||
| expect(parsed_response['error']).to match(/Please enter a search term/) |
There was a problem hiding this comment.
I had to update the expectation in this spec as the ImageSearch class does not have the limitation on the query length that the LegacyImageSearch did.
|
LGTM |
jmax-fearless
approved these changes
Jun 14, 2021
MothOnMars
added a commit
that referenced
this pull request
Aug 19, 2021
* SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code (#736) - remove legacy views, helpers & click-tracking code - remove "Compare Search Results" super admin feature - remove advanced-firstgov logic - remove deprecated or duplicated features - remove legacy seed & fixtures - remove legacy spec & feature helpers - redirect video news search path to search path - disable duplication check for specs * SRCH-2315 remove mobile-fu gem & related logic (#740) - replace custom "mobile" format with "html" - remove remaining "force_mobile_format" logic - remove deprecated parameters from permitted list - remove or update tests - remove or update VCR cassettes * SRCH-2108 remove bcrypt-ruby gem (#741) * SRCH-2314 remove legacy search classes (#747) * SRCH-2106 remove legacy assets (#750) - update asset-related gems * SRCH-2111 remove additional legacy SERP code (#751) - remove unused image assets and stylesheets - removed unused cucumber helpers * SRCH-2378 update addressable to 2.8.0 (#760) - bundle update gems * SRCH-2423 return assets used for affiliate type-ahead (#763)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRCH-2315 remove mobile-fu gem & related logic