Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRCH-2314 remove legacy search classes #747

Merged
merged 2 commits into from
Jul 12, 2021
Merged

SRCH-2314 remove legacy search classes #747

merged 2 commits into from
Jul 12, 2021

Conversation

MothOnMars
Copy link
Contributor

@MothOnMars MothOnMars commented Jul 7, 2021 •
edited
Loading

  • removes the ApiSearch, LegacyImageSearch, and ApiLegacyImageSearch classes

@MothOnMars MothOnMars marked this pull request as ready for review July 7, 2021 18:49
jmax-fearless
jmax-fearless approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@jmax-fearless jmax-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MothOnMars MothOnMars merged commit 9069c00 into GSA:feature/remove_legacy_serp_368 Jul 12, 2021
@MothOnMars MothOnMars deleted the legacy_search_2314 branch July 12, 2021 13:49
MothOnMars added a commit that referenced this pull request Aug 19, 2021
@MothOnMars
SRCH-368 remove legacy SERP code (#738)
2a36c39 
* SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code (#736)
- remove legacy views, helpers & click-tracking code
- remove "Compare Search Results" super admin feature
- remove advanced-firstgov logic
- remove deprecated or duplicated features
- remove legacy seed & fixtures
- remove legacy spec & feature helpers
- redirect video news search path to search path
- disable duplication check for specs

* SRCH-2315 remove mobile-fu gem & related logic (#740)
- replace custom "mobile" format with "html"
- remove remaining "force_mobile_format" logic
- remove deprecated parameters from permitted list
- remove or update tests
- remove or update VCR cassettes

* SRCH-2108 remove bcrypt-ruby gem (#741)

* SRCH-2314 remove legacy search classes (#747)

* SRCH-2106 remove legacy assets (#750)
- update asset-related gems

* SRCH-2111 remove additional legacy SERP code (#751)
- remove unused image assets and stylesheets
- removed unused cucumber helpers

* SRCH-2378 update addressable to 2.8.0 (#760)
- bundle update gems

* SRCH-2423 return assets used for affiliate type-ahead (#763)
@MyNameIsMissing MyNameIsMissing mentioned this pull request Aug 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmax-fearless jmax-fearless jmax-fearless approved these changes

Assignees

@jmax-fearless jmax-fearless

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MothOnMars @jmax-fearless