Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code #736

Merged

Conversation

MothOnMars
Copy link
Contributor

@MothOnMars MothOnMars commented Jun 4, 2021

SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code

  • remove legacy views, helpers & click-tracking code
  • remove "Compare Search Results" super admin feature
  • remove advanced-firstgov logic
  • remove deprecated or duplicated cucumber features
  • remove legacy seed & fixtures
  • remove legacy spec & feature helpers
  • redirect video news search path to search path
  • disable duplication check for specs

@MothOnMars MothOnMars force-pushed the legacy_serp_243 branch 4 times, most recently from d35551b to 6ed247f Compare June 4, 2021 19:14
@MothOnMars MothOnMars changed the base branch from master to feature/remove_legacy_serp_368 June 4, 2021 19:17
- remove legacy views, helpers & click-tracking code
- remove "Compare Search Results" super admin feature
- remove advanced-firstgov logic
- remove deprecated or duplicated features
- remove legacy seed & fixtures
- remove legacy spec & feature helpers
- redirect video news search path to search path
- disable duplication check for specs
@MothOnMars MothOnMars changed the base branch from feature/remove_legacy_serp_368 to master June 4, 2021 21:57
@MothOnMars MothOnMars changed the base branch from master to feature/remove_legacy_serp_368 June 4, 2021 21:57
@MothOnMars MothOnMars marked this pull request as ready for review June 7, 2021 14:22
@MothOnMars MothOnMars changed the title Legacy serp 243 SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code Jun 7, 2021
@@ -1,14 +1,10 @@
# frozen_string_literal: true

describe Affiliate do
fixtures :users, :affiliates, :site_domains, :features, :youtube_profiles, :memberships, :languages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! fixture removal!

Copy link
Contributor

@jmax-fearless jmax-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MothOnMars MothOnMars merged commit 22e3798 into GSA:feature/remove_legacy_serp_368 Jun 8, 2021
@MothOnMars MothOnMars deleted the legacy_serp_243 branch June 8, 2021 17:25
MothOnMars added a commit that referenced this pull request Aug 19, 2021
* SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code (#736)
- remove legacy views, helpers & click-tracking code
- remove "Compare Search Results" super admin feature
- remove advanced-firstgov logic
- remove deprecated or duplicated features
- remove legacy seed & fixtures
- remove legacy spec & feature helpers
- redirect video news search path to search path
- disable duplication check for specs

* SRCH-2315 remove mobile-fu gem & related logic (#740)
- replace custom "mobile" format with "html"
- remove remaining "force_mobile_format" logic
- remove deprecated parameters from permitted list
- remove or update tests
- remove or update VCR cassettes

* SRCH-2108 remove bcrypt-ruby gem (#741)

* SRCH-2314 remove legacy search classes (#747)

* SRCH-2106 remove legacy assets (#750)
- update asset-related gems

* SRCH-2111 remove additional legacy SERP code (#751)
- remove unused image assets and stylesheets
- removed unused cucumber helpers

* SRCH-2378 update addressable to 2.8.0 (#760)
- bundle update gems

* SRCH-2423 return assets used for affiliate type-ahead (#763)
@MyNameIsMissing MyNameIsMissing mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants