SRCH-368 remove legacy SERP code #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove legacy views, helpers & click-tracking code - remove "Compare Search Results" super admin feature - remove advanced-firstgov logic - remove deprecated or duplicated features - remove legacy seed & fixtures - remove legacy spec & feature helpers - redirect video news search path to search path - disable duplication check for specs
- replace custom "mobile" format with "html" - remove remaining "force_mobile_format" logic - remove deprecated parameters from permitted list - remove or update tests - remove or update VCR cassettes
- add comments re. deprecated gems
- update asset-related gems
- remove unused image assets and stylesheets - removed unused cucumber helpers
- bundle update gems
|
@jmax-fearless , this is ready for review. The changes in this PR have all been reviewed before, so this review is more to confirm that nothing untoward has snuck into this branch via a bad merge, for example. As I mentioned the CodeClimate failures "can't be displayed properly due to high issue volume", but I suspect they are all related to what appears to be new code, but is actually just code in renamed files that CC is processing as new code. With your OK, I'll mass-approve the CC failures. |
|
@jmax-fearless , ignore this PR until further notice. At least one more change is going into this branch... |
|
@jmax-fearless , this is ready for review. See review notes above. |
MyNameIsMissing
added a commit
that referenced
this pull request
Aug 23, 2021
SRCH-368 remove legacy SERP code (#738)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch to remove the legacy SERP, along with as much supporting code/files as possible, including assets, javascripts, specs, VCR cassettes, etc.