Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mibi/arc inheritance circle #272

Merged
merged 3 commits into from
Aug 22, 2021
Merged

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR makes Arc inheriting from Circle.

Related Tickets & Documents

This PR closes #262

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. labels Aug 21, 2021
@sonomirco sonomirco self-assigned this Aug 21, 2021
@sonomirco
Copy link
Collaborator Author

@cesarecaoduro and @d3ssy probably some tests between Arc and Circle are repetitive, what do you think?
This Pr only makes the inheritance of Circle into Arc, next step will be to integrate the new methods for ICurve and remove the properties for the NURBS and expose the ToNurbs method.

@d3ssy
Copy link
Collaborator

d3ssy commented Aug 21, 2021

@cesarecaoduro and @d3ssy probably some tests between Arc and Circle are repetitive, what do you think?
This Pr only makes the inheritance of Circle into Arc, next step will be to integrate the new methods for ICurve and remove the properties for the NURBS and expose the ToNurbs method.

Yes, since arc inherits from circle, any tests written for circle don't need to be repeated for arc. ArcTests should be testing any additional behavior if any.

@cesarecaoduro
Copy link
Collaborator

@sonomirco and @d3ssy I would probably keep both for readability

@sonomirco sonomirco merged commit 8662a45 into develop Aug 22, 2021
@sonomirco sonomirco deleted the dev/mibi/arc-inheritance-circle branch August 22, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arc inheritance from Circle
3 participants