Joincurve and extrema #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonomirco
added
enhancement 📢
src/GShark/Core/Trigonometry.cs
Outdated
| /// </summary> | ||
| /// <param name="curves">The sets of curve to sort.</param> | ||
| /// <returns>The set of curves sorted.</returns> | ||
| public static List<NurbsCurve> QuickSortCurve(IList<NurbsCurve> curves) |
There was a problem hiding this comment.
Why in Trigonometry?
There was a problem hiding this comment.
Yeah I know.
I moved it into CurveHelpr.
If we start to have more sorting algos in the future, we can call them into another class, or make this one even more generic.
cesarecaoduro
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds a quick sort algo used by the
JoinCurveto order the curves, and expose theExtremaas a method into theNurbsCurve.Related Tickets & Documents
This PR closes #331
This PR closes #335
Added tests?
Added to documentation?