Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mibi/dev/surface edges #380

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Mibi/dev/surface edges #380

merged 3 commits into from
Dec 30, 2022

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR added the method to extract the edges of the surface.
At the moment is limited only to surfaces of 4 edges.

Related Tickets & Documents

This PR closes #124

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. label Nov 14, 2021
@sonomirco sonomirco self-assigned this Nov 14, 2021
@d3ssy
Copy link
Collaborator

d3ssy commented Dec 30, 2022

can this be merged?

@sonomirco
Copy link
Collaborator Author

Yes.

@d3ssy d3ssy merged commit 0b4f1c2 into develop Dec 30, 2022
@d3ssy d3ssy deleted the mibi/dev/surface-edges branch December 30, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface extract edges
2 participants