adds point in polygon to Point3. #388
Conversation
d3ssy
added
the
enhancement 📢
| /// <param name="point">The point to test.</param> | ||
| /// <param name="polygon">The polygon to test against.</param> | ||
| /// <returns>Returns 0 if the point is outside the polygon or 1 if it is inside.</returns> | ||
| public int InPolygon(Polygon polygon) |
There was a problem hiding this comment.
What does it returns if it is coincident?
There was a problem hiding this comment.
Updated method to test for coincidence edge cases.
| /// <param name="point">The point to test.</param> | ||
| /// <param name="polygon">The polygon to test against.</param> | ||
| /// <returns>Returns 0 if the point is outside the polygon or 1 if it is inside.</returns> | ||
| public int InPolygon(Polygon polygon) |
There was a problem hiding this comment.
Could we have this operation at the level of the Curve
It sounds natural to think we are operating on the curve instead of the point.
What about moving this method to NurbsBase?
There was a problem hiding this comment.
This method is only applicable to Polygon as they are guaranteed to be planar curves. PointInCurve() given an arbitrary 3d curve is another can of worms.
I placed it in Point3 to match the Point3.InPlane() method.
There was a problem hiding this comment.
Shouldn't every curve be planar to perform this operation?
There was a problem hiding this comment.
Try and it in rhino and see 😄.
There was a problem hiding this comment.
Regardless of planarity, we will need a more computationally intensive method for NURBS that calculates ray intersections, and does closest point for coincidence checks. The logic should be the same. We can limit it to planar curves in the case of NURBS and throw error if it ain't.
…incidence edge cases.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Closes #86
Added tests?
Added to documentation?