Adds Mesh implementation #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AlanRynne, could we start to review this PR? |
sonomirco
added
enhancement 📢
Reviewed with Alan this AM based on comments on previous PR. Fresh commits coming in soon and then ready to merge! 🚀 |
d3ssy
reviewed
Jan 6, 2023
| var firstEdge = face.HalfEdge; | ||
| switch (adjacentFaces.Count) | ||
| { | ||
| case 3: // Triangle face |
d3ssy
requested changes
Jan 6, 2023
|
Hi all! Sorry for the delay on this I've been a bit busy lately! I'm planning on wrapping this up between today and tomorrow and leave it up to you guys to review for any improvements! 👍🏻 |
|
Noice. 🤘
…On Mon, Jan 16, 2023, 2:55 PM Alan Rynne ***@***.***> wrote:
Hi all! Sorry for the delay on this I've been a bit busy lately! I'm
planning on wrapping this up between today and tomorrow and leave it up to
you guys to review for any improvements! 👍🏻
—
Reply to this email directly, view it on GitHub
<#397 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPXUISKJTU56WRVROWYGI3WSWYUTANCNFSM6AAAAAATRVMNRY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@AlanRynne is this good to go?! |
|
@AlanRynne, any updates on this branch? |
|
Hey @sonomirco, @d3ssy! I would have sworn I had pinged you guys here to review this... but I seemed to have left my message unsent 🙇🏼♂️ I think this one is ready to go unless you have any particular opinions on any part of the code ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: