Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle vector #413

Merged
merged 2 commits into from May 4, 2023
Merged

Angle vector #413

merged 2 commits into from May 4, 2023

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

Fixed the problem with VectorAngleOnPlane outputting, as a result, the reflex angle and added some functionalities for collinear points.

Related Tickets & Documents

This PR
closes #407
closes #409

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco
Added remove collinear points.
66d9768 
Added are points clockwise.
@sonomirco
Improved the angle vector.
3d0c8ab 
Improved the unit test.
@sonomirco sonomirco added bug 🐛 Issues describing a bug or pull requests fixing a bug. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. minor Pull requests requiring a minor version update according to semantic versioning. labels May 4, 2023
@sonomirco sonomirco self-assigned this May 4, 2023
@sonomirco sonomirco added this to In progress in Core via automation May 4, 2023
@sonomirco sonomirco merged commit 14848cf into master May 4, 2023
2 checks passed
@sonomirco sonomirco deleted the dev/mibi/angle-vector branch May 4, 2023 01:33
Core automation moved this from In progress to Done May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sonomirco sonomirco

Labels
bug 🐛 Issues describing a bug or pull requests fixing a bug. minor Pull requests requiring a minor version update according to semantic versioning. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
Core
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determine if a list of points are in clockwise order Extra vector angle function.
1 participant
@sonomirco