Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package for Noetic #19

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

sfalexrog
Copy link

This P/R updates the package to be Noetic-compatible; in particular:

  • package.xml now uses version 3, and has conditional dependencies on python-websocket/python3-websocket for tests;
  • tests are updated to run on both Python2 and Python3;
  • CI is updated to run in Docker;
  • miscellaneous code fixes.

This package is required for web_video_server: RobotWebTools/web_video_server#104

@sfalexrog sfalexrog mentioned this pull request Aug 18, 2020
@Tobias-Fischer
Copy link

Any news on this? Would be great if it could be merged 👍

@flixr
Copy link

flixr commented Dec 15, 2020

Would be great indeed!

@JoaoFilipeResende
Copy link

This P/R updates the package to be Noetic-compatible; in particular:

* `package.xml` now uses version 3, and has conditional dependencies on `python-websocket`/`python3-websocket` for tests;

* tests are updated to run on both Python2 and Python3;

* CI is updated to run in Docker;

* miscellaneous code fixes.

This package is required for web_video_server: RobotWebTools/web_video_server#104

I've used this package with web_video_server in Noetic and everything is working just fine. Waiting for the merge. Thanks

@JMaravalhasSilva
Copy link

Why hasn't this been merged yet? :(

@duwudi
Copy link

duwudi commented Jan 10, 2021

Please merge 👍

roehling referenced this pull request in fkie/async_web_server_cpp Jan 12, 2021
@roehling
Copy link

Merged in fkie/async_web_server_cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants