-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dupe bug with Essentia condenser #27
Conversation
this goes together with GTNewHorizons/MagicBees#34, so its frozen until after stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduces a new dupe
I fixed issue with essentia insertion. And found another one: Essentia condenser cannot be filled more then with 64 essentia from ME system. That's issue of Thaumic Energistics. ThE hardcodes capacity of condenser to be equal 64 (because Thaumcraft API provides no ways to get capacity of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the dupe, couldn't find any new issues in my testing, seems good
Now this fix is finished. Essentia condenser should properly work with ThE and other accessors and provide full its capacity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
This class should really be split into 2-3 classes as access/master/plain are quite different and just blended together here.
This PR changes logic of Essentia condenser to allow access to essentia only using central block of multiblock.
Fixes dupe bug with bus from Thaumic Energistics attached to energy condenser.
Closes GTNewHorizons/GT-New-Horizons-Modpack#10522
Complex testing is necessary.