Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dupe bug with Essentia condenser #27

Merged
merged 8 commits into from
Dec 22, 2023
Merged

Conversation

OneEyeMaker
Copy link

This PR changes logic of Essentia condenser to allow access to essentia only using central block of multiblock.
Fixes dupe bug with bus from Thaumic Energistics attached to energy condenser.
Closes GTNewHorizons/GT-New-Horizons-Modpack#10522
Complex testing is necessary.

@OneEyeMaker OneEyeMaker requested a review from a team December 13, 2023 20:36
@Dream-Master Dream-Master added ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version and removed ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version labels Dec 13, 2023
@chochem chochem added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 13, 2023
@chochem
Copy link
Member

chochem commented Dec 13, 2023

this goes together with GTNewHorizons/MagicBees#34, so its frozen until after stable

@Alastors
Copy link

Screen_Shot_2023-12-13_at_9 16 42_PM Screen_Shot_2023-12-13_at_9 17 24_PM Screen_Shot_2023-12-13_at_9 17 33_PM Screen_Shot_2023-12-13_at_9 19 24_PM

This fixes the dupe when you only use the storage bus but it introduces a new dupe, that being:

when you insert essentia into the condenser from AE it doesn't actually take the essentia from AE now, it did take it from it formerly when actually inserted directly into the condenser, instead of jars.

I originally believed this was two separate bugs, however, I figured out that the 64 cap was only some terrible coding in TE that will need to be fixed on a later date, however, yes, the original dupe was fixed in this.

Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces a new dupe

@OneEyeMaker
Copy link
Author

I fixed issue with essentia insertion. And found another one: Essentia condenser cannot be filled more then with 64 essentia from ME system. That's issue of Thaumic Energistics. ThE hardcodes capacity of condenser to be equal 64 (because Thaumcraft API provides no ways to get capacity of IAspectContainer).
So I'm going to create PR to that mod to fix this part of issue.

@OneEyeMaker OneEyeMaker requested review from Alastors and a team December 14, 2023 13:44
@OneEyeMaker OneEyeMaker removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 18, 2023
Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the dupe, couldn't find any new issues in my testing, seems good

@OneEyeMaker OneEyeMaker requested review from TechnicianLP and a team December 22, 2023 18:45
@OneEyeMaker
Copy link
Author

Now this fix is finished. Essentia condenser should properly work with ThE and other accessors and provide full its capacity.

Copy link

@TechnicianLP TechnicianLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
This class should really be split into 2-3 classes as access/master/plain are quite different and just blended together here.

@Dream-Master Dream-Master merged commit 9541707 into master Dec 22, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix/essentia-condenser branch December 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable or fix the essentia condenser
5 participants