Skip to content

Add new --word-oriented option #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Add new --word-oriented option #38

merged 1 commit into from
Apr 1, 2021

Conversation

Gabriella439
Copy link
Owner

… and make that the new default

This also adds a --character-oriented option for people who prefer the
old behavior

@Gabriella439
Add new --word-oriented option
80a7b17 
… and make that the new default

This also adds a `--character-oriented` option for people who prefer the
old behavior
@Gabriella439 Gabriella439 mentioned this pull request Apr 1, 2021
Open
evanrelf
evanrelf approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@evanrelf evanrelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Maybe not in this PR, but in the future I think it would be better if the concept of coloring and orientation were separated. Adding spaces and newlines should be handled in a different function, IMO.

@Gabriella439 Gabriella439 merged commit c07cea9 into master Apr 1, 2021
@Gabriella439 Gabriella439 deleted the gabriel/word_oriented_2 branch April 1, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@evanrelf evanrelf evanrelf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @evanrelf