Output all differences between the compared derivations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if the set of input names to a derivation changed, then the set of matching-names inputs was not compared. This fixes the issue, allowing to use `nix-diff` as a tool for system administration: there, you have to know all the differences between the two system derivations, not only until an input set has a mismatching name (eg. a linux-kernel upgrade should not hide an nginx upgrade). Fixes Gabriella439#5.
|
For ease of reviewing, the changes here are:
|
|
Awesome! Thanks for doing this :) |
|
And thanks for accepting it! :) |
|
You're welcome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if the set of input names to a derivation changed,
then the set of matching-names inputs was not compared.
This fixes the issue, allowing to use
nix-diffas a tool for systemadministration: there, you have to know all the differences between the
two system derivations, not only until an input set has a mismatching
name (eg. a linux-kernel upgrade should not hide an nginx upgrade).
Fixes #5.