wrap sysinfo to defaultdict to return None #72
Conversation
|
Should we bother with the Hound's styling comments? If not go ahead and merge it. |
|
Hound says this is fine, though? |
pyHS100/tests/fakes.py
Outdated
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
closing bracket does not match visual indentation
pyHS100/tests/fakes.py
Outdated
| 'Rel.090105' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
closing bracket does not match visual indentation
pyHS100/tests/fakes.py
Outdated
| 'sw_ver': '1.5.5 Build 170623 ' | ||
| 'Rel.090105' | ||
| } | ||
| } |
There was a problem hiding this comment.
closing bracket does not match visual indentation
pyHS100/tests/fakes.py
Outdated
| 'rssi': -61, | ||
| 'sw_ver': '1.5.5 Build 170623 ' | ||
| 'Rel.090105' | ||
| } |
There was a problem hiding this comment.
closing bracket does not match visual indentation
…t, makes unsupported keys not to fail hard
rytilahti
force-pushed
the
hs100_sysinfo_defaultdict
branch
from
cb54b88
to
6f6533b
Compare
|
This fixes also #69, the location will be shown just as None then in status. |
|
Ok, merged this as there are no hound issues :-) |
|
I think the hound issues were on a different PR :-) Maybe I got something cached while looking at Files changed? Who knows, it's irrelevant anyways. PS.: Yup, it's #74. |
Wraps sysinfo with defaultdict returning None, makes it easier not to fail hard on missing values on different types of devices. Fixes #67