Focus indicator hiding plug nodules #5435
Comments
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Sep 20, 2023
We were scaling the size up to make the focus icon more prominent when the graph editor was zoomed out. But this has the unwanted side effect of obscuring more parts of the underlying UI when zoomed out. So while managing focus was easier, some other operations - such as making a connection - became _impossible_ at some zoom levels. This appears to have been further exacerbated by a bug whereby the default scaling was not consistent between 2K and 4K displays, as reported in GafferHQ#5435, making some operations impossible at common zoom levels. Removing this dynamic sizing does make focus management a little harder, but the fixed sizing maintains the relative importance of UI elements across all zoom levels. Let's see how folks get on with it. Fixes GafferHQ#5435.
github-project-automation
bot
moved this from In Progress
to Pending release
in Work in Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: Gaffer 1.2.10.1-linux
Description
The focus indicator can sometimes occlude the plug nodules, preventing interaction.
It seems to be particularly prevalent on shader nodes (because of the horizontal orientation) and high resolution displays (4k).
See attached gif for an example:
I was able to reproduce it on lower resolution displays as well, if I zoom out enough.
Note how there seems to be an issue with the detection box for the focus, where the focus indicator for the node lower in the screen is triggered when the mouse cursor is on the node above, near the right border, where the out plugs are.
The indicator itself may also be a bit larger the usual, also because of scaling, which compounds the issue.
I believe that fixing the detection box and scaling issues should be enough. But artists have also mentioned the possibility of having preferences to disable showing the focus indicator on mouse over.
Steps to reproduce
Debug log
Click to Expand
The text was updated successfully, but these errors were encountered: