Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are the removal of header keyword arguments:
dispersion_key
,first_wavelength
,dispersion_type
. These arguments were used solely for reconstructing the spectral axis. This PR implements the use of astropy WCS methods to reconstruct the spectral axis by recognizing the header format.The extension is now detected automatically but if many extensions are present in a file the user can still specify the extension to use. Solves issue #36.
Those 3 arguments are removed from
read_spectrum
,spectrum
andNirdustSpectrum
.