Add center option to drawImage command #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
changed the title
rmandelb
approved these changes
Sep 2, 2019
galsim/gsobject.py
Outdated
| @@ -1604,14 +1638,15 @@ def drawImage(self, image=None, nx=None, ny=None, bounds=None, scale=None, wcs=N | |||
| # Figure out what wcs we are going to use. | |||
| wcs = self._determine_wcs(scale, wcs, image) | |||
|
|
|||
| # Make sure offset is a PositionD | |||
| # Make sure offset and center are PositionD if entered as tuples. | |||
There was a problem hiding this comment.
I think these convenience functions also work if offset/center are entered as lists or a numpy array? Maybe this documentation could be something like "Make sure offset and center are PositionD, converting as necessary from other formats. If center was passed in as None, it will remain that way after _parse_center is run"?
|
Thanks both. Let's plan to release 2.2.0 on Friday. So if you have any systems you want to check to make sure we didn't break installation or anything, please check them this week. |
rmjarvis
added
the
base classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I lied. One more PR for version 2.2. This one is quick though. It's a feature I've wanted to add for a while now, but I never bothered to make an issue for.
I added
centeras an optional parameter to thedrawImagecommand. It's kind of just a convenience option, since it doesn't add any real capability that isn't already possible with theoffsetparameter. But getting a galaxy drawn at the right position withoffset, especially when letting GalSim automatically size the image for you, is kind of a pain. An example was in demo9, and it was pretty confusing.Now a whole bunch of code in demo9.py has gone away, and the draw command changed to
This makes me happy. :) I didn't propagate this change to anywhere else, but it wouldn't surprise me if there were other places where some code could look significantly simpler using
centerrather thanoffset.