Pass DYLD_FALLBACK_LIBRARY_PATH to scons #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to build GalSim against buggy Python builds (such as the one shipping with Anaconda; see ContinuumIO/anaconda-issues#498).
|
All looks fine to me. Thanks, Mario. I wasn't aware of this FALLBACK set of environment variables. I certainly don't have a problem with treating this one the same way as the others we do this for. Do you need me to cherry-pick this over to the 1.3 branch (and make a new revision there)? Or is this ok just being included in version 1.4 (probably <~ 1 month away)? |
|
Hi @rmjarvis -- merging to master only is fine, thanks! |
|
Sounds good to me. |
|
Hi All, Do we need have both this and the DYLD_LIBRARY_PATH option which we added at SLAC? |
|
I think most of the time, DYLD_LIBRARY_PATH is sufficient. But Mario wanted the ability to put things in the DYLD_FALLBACK_LIBRARY_PATH as well. I guess it can make it easier to build in some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to build GalSim against buggy Python builds (such as the one shipping with Anaconda; see ContinuumIO/anaconda-issues#498).
Note: in most cases one can get away with adding the path to libpython*.dyld onto
DYLD_LIBRARY_PATH, but having it onDYLD_FALLBACK_LIBRARY_PATHensures nothing else gets picked up from it that would otherwise get picked up from system paths. E.g., Anaconda also ships withlibz, but one probably wants to build against the system version, not the Anaconda one.Related issues: https://jira.lsstcorp.org/browse/SIM-1895, lsst-dm/legacy-galsim#9