Improve performance by changing ActionNotification to be a struct

Galad · Aug 8, 2020 · 1592b71 · 1592b71
1 parent c5a4b31
commit 1592b71
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 20 deletions.
diff --git a/src/Tranquire/Reporting/ActionNotification.cs b/src/Tranquire/Reporting/ActionNotification.cs
@@ -3,7 +3,7 @@
     /// <summary>
     /// Represent informations about the action execution
     /// </summary>
-    public class ActionNotification
+    public struct ActionNotification
     {
         /// <summary>
         /// The action that trigerred the notification

diff --git a/src/Tranquire/Reporting/RenderedReportingObserver.cs b/src/Tranquire/Reporting/RenderedReportingObserver.cs
@@ -52,11 +52,6 @@ public void OnError(Exception error)
         /// <inheritsdoc />
         public void OnNext(ActionNotification value)
         {
-            if (value == null)
-            {
-                throw new ArgumentNullException(nameof(value));
-            }
-
             Observer.OnNext(Renderer(value));
         }
 
@@ -67,9 +62,9 @@ public void OnNext(ActionNotification value)
         /// <returns></returns>
         public static string DefaultRenderer(ActionNotification notification)
         {
-            if (notification == null)
+            if (notification.Content == null)
             {
-                throw new ArgumentNullException(nameof(notification));
+                return "Unknown action";
             }
 
             switch (notification.Content.NotificationContentType)

diff --git a/src/Tranquire/Reporting/XmlDocumentObserver.cs b/src/Tranquire/Reporting/XmlDocumentObserver.cs
@@ -67,9 +67,9 @@ public void OnError(Exception error)
         /// <inheritsdoc />
         public void OnNext(ActionNotification value)
         {
-            if (value == null)
+            if (value.Content == null)
             {
-                throw new ArgumentNullException(nameof(value));
+                return;
             }
 
             switch (value.Content.NotificationContentType)

diff --git a/tests/Tranquire.Tests/Reporting/ReportingActorTests.cs b/tests/Tranquire.Tests/Reporting/ReportingActorTests.cs
@@ -195,7 +195,7 @@ public void Sut_AllMethods_ShouldCallOnNext(
                 new ActionNotification(action, 1, new BeforeActionNotificationContent(date, commandType)),
                 new ActionNotification(action, 1, new AfterActionNotificationContent(expectedDuration))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         [Theory, MemberData(nameof(NotifyingTestCases))]
@@ -250,7 +250,7 @@ BeforeActionNotificationContent before()
                 new ActionNotification(actions[1], 2, new AfterActionNotificationContent(expectedDurations[1])),
                 new ActionNotification(actions[0], 1, new AfterActionNotificationContent(expectedDurations[0]))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         [Theory, MemberData(nameof(ExecutionTestCases))]
@@ -305,7 +305,7 @@ public void Sut_AllMethods_WhenErrorOccurs_ShouldCallOnNext(
                 new ActionNotification(action, 1, new BeforeActionNotificationContent(date, commandType)),
                 new ActionNotification(action, 1, new ExecutionErrorNotificationContent(exception, expectedDuration))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         [Theory, MemberData(nameof(NotifyingTestCases))]
@@ -364,7 +364,7 @@ BeforeActionNotificationContent before()
                 new ActionNotification(actions[1], 2, new ExecutionErrorNotificationContent(exception, expectedDuration)),
                 new ActionNotification(actions[0], 1, new ExecutionErrorNotificationContent(exception, expectedDuration))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         [Theory, ReportingActorAutoData]
@@ -446,7 +446,7 @@ ThenAction<object, string> thenAction
                 new ActionNotification(thenAction, 1, new BeforeThenNotificationContent(date, thenAction.Question)),
                 new ActionNotification(thenAction, 1, new AfterThenNotificationContent(expectedDuration, ThenOutcome.Pass))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         [Theory, ReportingActorAutoData]
@@ -476,7 +476,7 @@ TimeSpan expectedDuration
                 new ActionNotification(thenAction, 1, new BeforeThenNotificationContent(date, thenAction.Question)),
                 new ActionNotification(thenAction, 1, new AfterThenNotificationContent(expectedDuration, ThenOutcome.Error, error))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
 
         private static System.Action[] _assertions = new System.Action[]
@@ -531,7 +531,7 @@ TimeSpan expectedDuration
                 new ActionNotification(thenAction, 1, new BeforeThenNotificationContent(date, thenAction.Question)),
                 new ActionNotification(thenAction, 1, new AfterThenNotificationContent(expectedDuration, ThenOutcome.Failed, expectedException))
             };
-            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes());
+            observer.Values.Should().BeEquivalentTo(expected, o => o.RespectingRuntimeTypes().ComparingByMembers<ActionNotification>());
         }
     }
 }
diff --git a/tests/Tranquire.Tests/Reporting/XmlDocumentObserverTests.cs b/tests/Tranquire.Tests/Reporting/XmlDocumentObserverTests.cs
@@ -231,7 +231,8 @@ XmlReportItem createItem(
                                     (notifications, a) => notifications
                                         .Insert(0, new ActionNotification(a.action, a.i + 1, new BeforeActionNotificationContent(DateTimeOffset.MinValue, a.commandType)))
                                         .Add(new ActionNotification(a.action, a.i + 1, new AfterActionNotificationContent(TimeSpan.FromSeconds(a.i))))
-                                ),
+                                )
+                                .ToArray(),
                         actions.Select((a,i) => (a.action, a.commandType, i))
                                                   .Select(a => createItem(a.commandType, a.action.Name, DateTimeOffset.MinValue, a.i * 1000))
                                                   .Reverse()
@@ -260,7 +261,8 @@ XmlReportItem createItem(
                                         .Add(new ActionNotification(a.action, a.i + 1,
                                                     new ExecutionErrorNotificationContent(a.exception, TimeSpan.FromSeconds(a.i))
                                                     ))
-                                ),
+                                )
+                                .ToArray(),
                         actions.Select((a,i) => (a.action, a.commandType, exception, i))
                                                   .Select(a =>
                                                     createItem(

diff --git a/tests/Tranquire.Tests/ThenActionTests.cs b/tests/Tranquire.Tests/ThenActionTests.cs
@@ -17,7 +17,6 @@ public void Sut_ConstructorInitializedMember(ConstructorInitializedMemberAsserti
         {
             assertion.Verify<ThenAction<object, string>>(a => new object[]
             {
-                a.Question,
                 a.VerifyAction
             });
         }