Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asm] Fix disasm() for mips64, powerpc64, sparc64 #1603

Merged
merged 6 commits into from
Jun 28, 2020
Merged

[asm] Fix disasm() for mips64, powerpc64, sparc64 #1603

merged 6 commits into from
Jun 28, 2020

Conversation

heapcrash
Copy link
Collaborator

@heapcrash heapcrash commented Jun 23, 2020 •
edited
Loading

Closes #1564

@heapcrash heapcrash mentioned this pull request Jun 23, 2020
Closed
@zachriggle
Copy link
Member

Shouldn't this target stable @heapcrash?

@Arusekk
Copy link
Member

Arusekk commented Jun 24, 2020

Looks like we need to install binutils-sparc64-linux-gnu in the flow, or better, binutils-multiarch (we would need some detection logic for it, though).

@heapcrash
Copy link
Collaborator Author

Looks like everything passed except the pwnlib.ui tests being flaky

@heapcrash heapcrash merged commit 1a9dce0 into Gallopsled:dev Jun 28, 2020
@heapcrash heapcrash deleted the issue-1564 branch May 31, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disasm() doesn't work for context.arch='sparc64'
3 participants
@heapcrash @zachriggle @Arusekk