Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Avoid typed-ast dependency #195

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Python: Avoid typed-ast dependency #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-python@v2
with:
python-version: '3.7'
python-version: '3.11'
- uses: abatilo/actions-poetry@v2.1.4
with:
poetry-version: 1.1.11
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
poetry install
- name: Typecheck python code
working-directory: ./python
run: poetry run mypy argo_client
run: poetry run mypy --install-types --non-interactive argo_client
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a bit unfortunate, but perhaps unavoidable. mypy-0.900 do not install third-party libraries' type packages unless you explicitly opt in to it with --install-types. Moreover, I'm unclear if it's possible to make mypy always use --install-types as a pyproject.toml configuration option. At the very least, I can't find anything about this in the list of configuration options.

- name: Build
run: |
cabal build all
Expand Down
149 changes: 40 additions & 109 deletions python/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ include = [
"Bug Tracker" = "https://github.com/GaloisInc/argo/issues"

[tool.poetry.dependencies]
python = ">=3.7.0,<4"
python = ">=3.8.0,<4"
requests = "^2.26.0"
urllib3 = ">=1.26.5"

[tool.poetry.dev-dependencies]
mypy = "^0.812"
mypy = "^0.991"

[build-system]
requires = ["poetry>=1.1.4", "setuptools>=40.8.0"]