Structured assembled instructions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
force-pushed
the
lb/assembled-instruction
branch
3 times, most recently
from
8e8899e
to
0e76125
Compare
Add an intermediate datastructure that consists of all the bytes of an assembled instruction, but labeled and nested. This aids considerably in debugging when assembly goes wrong.
langston-barrett
force-pushed
the
lb/assembled-instruction
branch
from
0e76125
to
98b7bb3
Compare
langston-barrett
changed the title
travitch
approved these changes
Apr 27, 2020
|
Kevin says that this has been built successfully against saw-script, the indicators are a bit misleading in that regard because they restart when there is a new downstream commit. However, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an intermediate datastructure that consists of all the bytes of an assembled instruction, but labeled and nested. This aids considerably in debugging when assembly goes wrong (a la #20).
One possible concern is performance, but with enough inlining, the constructors should meet with the destructors and be optimized away at compile-time. I'd appreciate any advice folks have on how to make sure this is happening.