lean4 submodule bump tweaks (for Lean4 commit ec9f4b579dc6b4a20407d27… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…35f8ad91de29bfdb5)
pnwamk
commented
Apr 28, 2020
| @@ -574,7 +574,7 @@ obj_res lean_llvm_decomposeValue(b_obj_arg v_obj, obj_arg r) { | |||
|
|
|||
| // argument_value : Nat -> value_decomposition | |||
| x = alloc_cnstr(2, 1, 0); | |||
| cnstr_set_scalar(x, 0, box(a->getArgNo())); | |||
| cnstr_set(x, 0, box(a->getArgNo())); | |||
There was a problem hiding this comment.
This is the change I'm not positive is correct =\
Here is a commit removing various usages of cnstr_get_scalar and cnstr_set_scalar right before the commit that removed those two template functions from lean4: leanprover/lean4@16d88b0
Those don't end up using cnstr_set... however, there is other code in the test directories that seems very similar to what we're doing here, e.g. https://github.com/leanprover/lean4/blob/ec9f4b579dc6b4a20407d2735f8ad91de29bfdb5/src/tests/util/object.cpp#L266
So yah, I'm not sure.
|
Also, this PR builds with the associated bumps in That's obviously not running any tests though =\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…35f8ad91de29bfdb5)