Add packet example and integration test #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebendavis
force-pushed
the
bd/packet-integration-test
branch
2 times, most recently
from
95ea397
to
d0c8633
Compare
thebendavis
force-pushed
the
bd/packet-integration-test
branch
from
d0c8633
to
7c7191a
Compare
3 tasks
|
This looks fine to me, I think including at least one example that bypasses the normal "scripting" interface makes sense as a sanity check. I think it also makes sense to test it both via docker and natively once #418 is addressed. |
danmatichuk
reviewed
Jul 10, 2024
This was referenced Jul 10, 2024
subsumed by docker integration test, see #417
Thanks for the review! I have flagged the appropriate items for followup in relevant issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a standalone example (
packet.exe) and an integration test. Beyond testing basic verifier functionality, this is intended to provide an integration test of the 1) terminal user interaction, and 2) resulting equivalence condition, in ways that the other automated tests do not. The integration test is implemented as anexpectscript that captures a subset of the expected output including a key clause of the equivalence condition, and will alert / need to be updated if this output changes during evolution of the PATE verifier.This integration test has been added to the
dockerCI job. I have not additionally added it to thebuildCI job because that job usescabal build pkg:patewhich breaks subsequent use of./pate.sh, which is the interface used by the integration test. This issue is captured separately in #418 and is outside of the scope of this PR.