Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIKE SAW Memory Safety Properties #5

Merged
merged 126 commits into from
Aug 20, 2019

Conversation

pedrotst
Copy link

@pedrotst pedrotst commented Aug 2, 2019

Issue # (if available):

Description of changes:

This pull request adds SAW scripts for BIKE Memory Safety Properties.

A couple of adaptations had to be done in the build process to accommodate both SIKE and BIKE tests to run independently.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

alexw91 and others added 30 commits April 3, 2019 09:28
…IKE as a part of s2n and run one sanity test.

Update BIKE with Makefiles to fix Travis build

Remove inline complier warning suppression, use compiler flags instead. Do not include bike types.h in external files
…x other issues from clang build and FIPS openssl build

Do not compile post-quantum algorithms when using FIPS OpenSSL
zz85 and others added 22 commits July 25, 2019 09:10
1. Print pid in print_s2n_error function
2. Set SA_NOCLDWAIT to prevent creating zombies
3. close fd in the main event loop after forking
Make CertificateStatus optional in client mode

According to RFC6066 Section 8, server may choose not to send
"CertificateStatus" message even if it has sent "status_request"
extension in ServerHello message.
…xtension

Add client supported_versions extension
1. Skip unsupported extensions
2. Use a bitmask to perform the uniqueness check
Use CMake pthreads (Threads) package to manage pthreads dependency
Copy link

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrotst looks good, please address the inline comments

crypto_kem_dec_unsuccessful_spec;

// NOTE: Step 1 of 2 - conditioned on a SUCCESS result
// crypto_kem_dec_successful_ov <- verify_unint "BIKE1_L1_crypto_kem_dec"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment

///////////////////////////////////////////////////////////////////////////////
// Proof commands

// verify "convert_to_redundant_rep" [] (convert_to_redundant_rep_spec 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the one below?

verify_pathsat "__breakpoint__generate_sparse_fake_rep_first_loop#generate_sparse_fake_rep"
generate_sparse_fake_rep_O
generate_sparse_fake_rep_first_loop_spec;
// verify_pathsat "__breakpoint__generate_sparse_fake_rep_second_loop#generate_sparse_fake_rep"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment

@@ -44,7 +44,7 @@ let count_ones_spec n = do {
///////////////////////////////////////////////////////////////////////////////
// Proof commands

// verify "convert_to_redundant_rep" [] (convert_to_redundant_rep_spec 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the next line, delete

@andreistefanescu andreistefanescu merged commit 8b77f9d into GaloisInc:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.