Use lumberjack as the logging core #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regularizes the logging infrastructure to not emit messages and use the logging API directly. This will let us more easily support sending logs to files as well as the in-memory buffer. This uses a custom log message type modeled after the one from lumberjack. It attempts to hide the fact that it uses lumberjack to make future updates to call sites a bit easier (hopefully).
This includes commands to change the file log target at run-time
Switching architectures threw away the file logger before this change. This change also creates the directory for the log file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regularizes the logging infrastructure to not emit messages and use the
logging API directly. This will let us more easily support sending logs to
files as well as the in-memory buffer.
This uses a custom log message type modeled after the one from lumberjack. It
attempts to hide the fact that it uses lumberjack to make future updates to call
sites a bit easier (hopefully).