Fix incorrect range reduction code in SWord shifts #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the SWord module for dynamically-sized words, one has to match the sizes of shift operations before passing them down to the main representation code. When the shift amount has a larger bit-width than the word to be shifted, a range reduction is required so the truncation of the shift amount still gets the correct result. Previously, this reduction was being done incorrectly by computing a `max` instead of a `min`. Fixes #126
robdockins
added a commit
to GaloisInc/cryptol
that referenced
this pull request
Jun 17, 2021
This bug was fixed in What4 via GaloisInc/what4#127 which was included in What4 version 1.2. Fixes #1210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the SWord module for dynamically-sized words, one has to
match the sizes of shift operations before passing them down to the
main representation code. When the shift amount has a larger bit-width
than the word to be shifted, a range reduction is required so the
truncation of the shift amount still gets the correct result. Previously,
this reduction was being done incorrectly by computing a
maxinsteadof a
min.Fixes #126