This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix grabbing urls from srcset attributes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first attempt at this (312ecd9) was too naive, it didn't take urls with commas in them into account. In this second attempt, I've tried to tdd things so that I know we can handle a wider range of values. I've used https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img as a guide into figuring out possible values.
ljharb
approved these changes
Jun 10, 2018
| export default function getUrlsFromSrcset(value) { | ||
| const result = []; | ||
| let match; | ||
| while (match = SRCSET_ITEM.exec(value)) { // eslint-disable-line no-cond-assign |
There was a problem hiding this comment.
You can use https://npmjs.com/string.prototype.matchall for this :-D
There was a problem hiding this comment.
Thanks! I'll make that change after I publish.
lencioni
approved these changes
Jun 10, 2018
trotzig
added a commit
that referenced
this pull request
Jun 11, 2018
As pointed out by @ljharb in a previous PR: #224 (review) Multiple benefits here: - we avoid the while-loop - no mutation of the lastIndex property of the regexp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at this (312ecd9) was too naive, it didn't take urls
with commas in them into account. In this second attempt, I've tried to
tdd things so that I know we can handle a wider range of values.
I've used https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img
as a guide into figuring out possible values.