Remove simdnoise for terraingen #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, it was a system ordering problem. Now the Debug UI systems run before the player input processing systems so that any interaction with the debug UIs prevents cursor grabbing, which feels much more natural. |
meyerzinn
force-pushed
the
remove-simdnoise
branch
from
3c81ec7
to
5de44a3
Compare
Game4all
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simdnoise does not work on ARM and is not significantly faster than noise-rs. This PR fixes camera controls on Mac and switches terrain generation to use noise-rs (which requires some adaptation of the parameters and noise algorithm). We can fine tune the specifics here.