Add rotation to integration #1305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
- Coverage 36.25% 36.20% -0.05%
==========================================
Files 395 396 +1
Lines 31537 31578 +41
==========================================
Hits 11433 11433
- Misses 20104 20145 +41 ☔ View full report in Codecov by Sentry. |
fallenatlas
force-pushed
the
1242-handle-body-rotation-on-integration
branch
from
d054db1
to
56900aa
Compare
roby2014
approved these changes
Sep 10, 2024
|
@luishfonseca will only be able to review this PR in 5 days. |
|
I should probably be removed from the list of reviewers during P1, I'll have more time again on P2 onwards |
RiscadoA
requested review from
a team,
DiogoMendonc-a,
tomas7770 and
Scarface1809
and removed request for
luishfonseca,
a team,
DiogoMendonc-a and
Scarface1809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply torque and angular impulses on integration to rotate the bodies.
Resources: https://research.ncl.ac.uk/game/mastersdegree/gametechnologies/physicstutorials/3angularmotion/Physics%20-%20Angular%20Motion.pdf
Checklist