Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all configuration into pyproject.toml, add x86 mac to CI #86

Merged
merged 3 commits into from
May 11, 2024

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Apr 5, 2024

This PR introduces more modern linters and formatters and merges all config into pyproject.toml

All .py file changes are formatting related to use the more popular black formatting style implemented by ruff, the rest is actual changes.

This PR moves all tooling configuration into one centralized pyproject.toml

@pavelzw pavelzw marked this pull request as draft April 5, 2024 17:53
@pavelzw pavelzw marked this pull request as ready for review April 5, 2024 18:06
@p-fruck
Copy link
Contributor

p-fruck commented Apr 7, 2024

Hi @pavelzw, not a maintainer of the project but can you please separate your commits such that the first commit includes all structural changes (including ruff, updating scripts and CI, etc) and the second commit performs the actual formatting? This makes it easier to review and audit/reproduce the code ;)

@pavelzw
Copy link
Contributor Author

pavelzw commented Apr 8, 2024

Happy to re-do this once #78 went through as just reformatting is probably a lot easier than actually fixing merge conflicts.

@pavelzw pavelzw force-pushed the modernize-python branch 3 times, most recently from c924b9a to 776f3b9 Compare May 10, 2024 13:03
@pavelzw
Copy link
Contributor Author

pavelzw commented May 10, 2024

@Garmelon this is ready for review

@pavelzw pavelzw changed the title Modernize python tooling Modernize python tooling, also build for macOS x86 May 10, 2024
Copy link
Owner

@Garmelon Garmelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to switch to ruff right now (maybe in the future though), but the remaining changes look good. I also like the merging of tooling config into pyproject.toml.

Could you please remove ruff and the resulting reformatting?

.github/workflows/build-and-release.yml Outdated Show resolved Hide resolved
@pavelzw
Copy link
Contributor Author

pavelzw commented May 10, 2024

Should I keep the ruff linter instead of isort and flake8 and only revert the ruff format part or remove ruff altogether? I'm not sure flake8 supports configuration inside pyproject.toml and ruff should support a similar featureset like both tools.

@Garmelon
Copy link
Owner

I want to keep using the old tools for now. They're written in python, which makes them easier to use in my weird nixos setup (no issues with any compiled binaries).

@pavelzw pavelzw changed the title Modernize python tooling, also build for macOS x86 Move all configuration into pyproject.toml, add x86 mac to CI May 11, 2024
@pavelzw pavelzw requested a review from Garmelon May 11, 2024 08:32
Co-authored-by: Garmelon <joscha@plugh.de>
@Garmelon Garmelon merged commit b29b6f9 into Garmelon:master May 11, 2024
5 checks passed
@pavelzw pavelzw deleted the modernize-python branch May 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants