-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all configuration into pyproject.toml, add x86 mac to CI #86
Conversation
7aa5af2
to
906953e
Compare
Hi @pavelzw, not a maintainer of the project but can you please separate your commits such that the first commit includes all structural changes (including ruff, updating scripts and CI, etc) and the second commit performs the actual formatting? This makes it easier to review and audit/reproduce the code ;) |
Happy to re-do this once #78 went through as just reformatting is probably a lot easier than actually fixing merge conflicts. |
c924b9a
to
776f3b9
Compare
@Garmelon this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to switch to ruff right now (maybe in the future though), but the remaining changes look good. I also like the merging of tooling config into pyproject.toml
.
Could you please remove ruff and the resulting reformatting?
Should I keep the ruff linter instead of isort and flake8 and only revert the ruff format part or remove ruff altogether? I'm not sure flake8 supports configuration inside pyproject.toml and ruff should support a similar featureset like both tools. |
I want to keep using the old tools for now. They're written in python, which makes them easier to use in my weird nixos setup (no issues with any compiled binaries). |
Co-authored-by: Garmelon <joscha@plugh.de>
This PR introduces more modern linters and formatters and merges all config intopyproject.toml
All.py
file changes are formatting related to use the more popular black formatting style implemented by ruff, the rest is actual changes.This PR moves all tooling configuration into one centralized
pyproject.toml