Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info Window updates #18

Merged
merged 1 commit into from
Apr 4, 2012
Merged

Info Window updates #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ td.space-hog {
display: inline-block;
}

.info-window-content b1 {

color: green;
font-weight: bold;
font-size: 9pt ;
margin-top: 10px;
display: inline-block;
}

.info-window-content b:first-child {
margin-top: 0;
}
Expand Down
2 changes: 1 addition & 1 deletion js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ App = (function () {
'<div class="info-window-content">',
'<b>', data.name, '</b><br>',
data.address, '<br>',
'<b>', localeData.labels.installations, '</b>',
'<b1>', localeData.labels.installations, '</b1>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À moins de faire erreur <b1> n'est pas un tag HTML valide? Pouquoi ne pas juste utiliser une classe css <b class="green-label"> ou un truc du genre...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex,

SVP tu peut corrig pour le mettre de la bonne faon! (sorry j'ai fait a rapidement) sauf SVP s'assurer que a reste comme prsentement dployer sur le site , i.e. Installations en vert et plus petit font....(trs important)

Si tu pouvait ce soir crer le lien qui permettra de voir le site en anglais ou franais et de plus changer le context localiser des Twitter et Facebook button

Si tu as une chance appelle-moi plus tard ce soir pour que nous puissions discuter

Merci,
sf

Stphane Frchette
mobile: +1 (819) 319-2935
email: stephanefrechette@me.com
.tel: http://stephanefrechette.tel
GatineauOuverte.org - Initiative citoyenne, donnes ouvertes

On 2012-04-04, at 4:19 PM, Alexandre Potvin Latreille wrote:

@@ -185,7 +185,7 @@ App = (function () {
'

',
'', data.name, '
',
data.address, '
',

  •            '<b>', localeData.labels.installations, '</b>',

  •            '<b1>', localeData.labels.installations, '</b1>',

moins de faire erreur <b1> n'est pas un tag HTML valide? Pouquoi ne pas juste utiliser une classe css <b class="green-label"> ou un truc du genre...

Reply to this email directly or view it on GitHub:
https://github.com/GatineauOuverte/parcs/pull/18/files#r647231

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'aurai pas le temps ce soir Steph, mais je devrais pouvoir faire ça demain soir! D'ici là, je vais ouvrir des issues sur GitHub et peut-être que quelqu'un le fera...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de prob
Merci Alex
À+

Sent from my iPhone

Stéphane Fréchette
mobile: +1 (819) 319-2935
e-mail: stephanefrechette@me.com
.tel: http://stephanefrechette.tel
GatineauOuverte.org - Initiative citoyenne, données ouvertes

On 2012-04-04, at 6:44 PM, Alexandre Potvin Latreillereply@reply.github.com wrote:

@@ -185,7 +185,7 @@ App = (function () {
'

',
'', data.name, '
',
data.address, '
',

  •            '<b>', localeData.labels.installations, '</b>',

  •            '<b1>', localeData.labels.installations, '</b1>',

Je n'aurai pas le temps ce soir Steph, mais je devrais pouvoir faire ça demain soir! D'ici là, je vais ouvrir des issues sur GitHub et peut-être que quelqu'un le fera...

Reply to this email directly or view it on GitHub:
https://github.com/GatineauOuverte/parcs/pull/18/files#r648060

'<ul>', listContentHtml, '</ul>',
'</div>'
].join(''));
Expand Down