Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imporve UX when there is no img or bg-img #158

Merged
merged 4 commits into from
May 10, 2016
Merged

imporve UX when there is no img or bg-img #158

merged 4 commits into from
May 10, 2016

Conversation

szrenwei
Copy link
Contributor

@szrenwei szrenwei commented May 8, 2016

If there's no img or bg-img, use a 1px transparent data uri as a fallback, otherwise the user will be blocked for 10s.

@Gaya
Copy link
Owner

Gaya commented May 10, 2016

Thanks for this PR. Can you revert all the files expect src/ImagePreloader/index.js so I can bump and build myself?
I will merge when you're done.

@szrenwei
Copy link
Contributor Author

@Gaya done.

@Gaya Gaya merged commit 8ec971e into Gaya:master May 10, 2016
@Gaya
Copy link
Owner

Gaya commented May 10, 2016

Thanks! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szrenwei @Gaya