Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#102) Codeowners setup #115

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

bhosale2
Copy link
Collaborator

Fixes #102, @armantekinalp, and @skim0119 feel free to edit orderings and reallocate folders as you see fit (with me in the loop).

@bhosale2 bhosale2 added the enhancement New feature or request label Jun 22, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jun 22, 2022
@bhosale2 bhosale2 self-assigned this Jun 22, 2022
@bhosale2 bhosale2 linked an issue Jun 22, 2022 that may be closed by this pull request
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #115 (1edde13) into update-0.3.0 (376ece2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           update-0.3.0     #115      +/-   ##
================================================
+ Coverage         87.13%   87.15%   +0.02%     
================================================
  Files                41       41              
  Lines              2550     2554       +4     
  Branches            347      347              
================================================
+ Hits               2222     2226       +4     
  Misses              306      306              
  Partials             22       22              
Impacted Files Coverage Δ
elastica/rod/factory_function.py 97.69% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7813c2b...1edde13. Read the comment docs.

@bhosale2 bhosale2 merged commit d138ae9 into GazzolaLab:update-0.3.0 Jun 23, 2022
@bhosale2 bhosale2 deleted the 102_codeowners_setup branch June 23, 2022 12:35
@bhosale2 bhosale2 mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODEOWNERS setup
4 participants