Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Damper class #123

Merged
merged 12 commits into from
Jul 5, 2022
Merged

Filter Damper class #123

merged 12 commits into from
Jul 5, 2022

Conversation

bhosale2
Copy link
Collaborator

@bhosale2 bhosale2 commented Jul 4, 2022

Fixes #119, by adding a FilterDamper class. @armantekinalp feel free to edit at places (docs, specifically notes) as you see fit.

@bhosale2 bhosale2 added the enhancement New feature or request label Jul 4, 2022
@bhosale2 bhosale2 self-assigned this Jul 4, 2022
@bhosale2 bhosale2 requested a review from skim0119 as a code owner July 4, 2022 00:44
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 4, 2022
@bhosale2 bhosale2 linked an issue Jul 4, 2022 that may be closed by this pull request
Filter Damping addition to the damping module #119
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #123 (eae07f4) into update-0.3.0 (3a4963c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           update-0.3.0     #123      +/-   ##
================================================
+ Coverage         87.32%   87.41%   +0.09%     
================================================
  Files                44       44              
  Lines              2619     2639      +20     
  Branches            353      355       +2     
================================================
+ Hits               2287     2307      +20     
  Misses              310      310              
  Partials             22       22
Impacted Files Coverage Δ
elastica/dissipation.py 95.45% <100.00%> (+3.45%) ⬆️
elastica/rod/factory_function.py 97.69% <100.00%> (ø)
elastica/typing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2008f29...eae07f4. Read the comment docs.

armantekinalp
armantekinalp approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skim0119
skim0119 requested changes Jul 5, 2022
View reviewed changes
elastica/typing.py Outdated Show resolved Hide resolved
elastica/dissipation.py Outdated Show resolved Hide resolved
elastica/dissipation.py Show resolved Hide resolved
elastica/dissipation.py Outdated Show resolved Hide resolved
elastica/dissipation.py Outdated Show resolved Hide resolved
elastica/dissipation.py Show resolved Hide resolved
elastica/dissipation.py Outdated Show resolved Hide resolved
bhosale2 and others added 2 commits July 5, 2022 16:17
@bhosale2 @skim0119
Update elastica/dissipation.py
9e08b33 
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
@bhosale2 @skim0119
Update elastica/typing.py
f35431c 
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
@skim0119 skim0119 changed the title (#119) Filter Damper class Filter Damper class Jul 5, 2022
bhosale2 and others added 5 commits July 5, 2022 17:15
@bhosale2 @armantekinalp
docs: Update elastica/dissipation.py with thesis citation
a93571a 
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
@bhosale2 @armantekinalp
docs: Update elastica/dissipation.py with ref format
bc01c83 
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
@bhosale2
docs: filter class name change
80ac39a
@bhosale2
docs: changes per review
4e606da
@bhosale2
refac: class name change in tests
7b64de1
@bhosale2 bhosale2 requested a review from skim0119 July 5, 2022 18:16
skim0119
skim0119 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work!

@skim0119 skim0119 merged commit a8cb32c into GazzolaLab:update-0.3.0 Jul 5, 2022
@bhosale2 bhosale2 deleted the 119_filter_damper branch July 5, 2022 18:44
@bhosale2 bhosale2 mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@skim0119 skim0119 skim0119 approved these changes

Assignees

@bhosale2 bhosale2

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.

Filter Damping addition to the damping module
4 participants
@bhosale2 @codecov-commenter @skim0119 @armantekinalp