-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #128: save_every condition in ExportCallBack #125
Fix #128: save_every condition in ExportCallBack #125
Conversation
The previous implementation would require "skip_step" and "save_every" to be synchronous in order to trigger. Now, we instead count the number of time steps since the last save and trigger the save whenever this number is higher or equal than the "save_every" parameter
@mstoelzle Hi, Thank you for your interest in PyElastica. Can you clarify the bug a little more, maybe specify the expected behavior? Maybe I should have named and documented the variables more clearly; On the other hand, If you have a different idea to implement, we would appreciate it if you make an issue to discuss further. |
…inimizing any potential delays for saving into storage
Codecov Report
@@ Coverage Diff @@
## update-0.2.4 #125 +/- ##
=============================================
Coverage 87.09% 87.09%
=============================================
Files 40 40
Lines 2534 2534
Branches 343 343
=============================================
Hits 2207 2207
Misses 305 305
Partials 22 22
Continue to review full report at Codecov.
|
@mstoelzle Thanks. I'm squash-merging, so please re-clone downstream if there is any. Regarding the path assertion, I'll disable the assertion for now (536a49e) and make an update with #127 later. |
The previous implementation would require "skip_step" and "save_every" to be synchronous in order to trigger. Now, we instead count the number of time steps since the last save and trigger the save whenever this number is higher or equal than the "save_every" parameter