Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct endpoint forces docstring #157

Merged
merged 1 commit into from
Jul 23, 2022
Merged

docs: correct endpoint forces docstring #157

merged 1 commit into from
Jul 23, 2022

Conversation

bhosale2
Copy link
Collaborator

Fixes #154.

@bhosale2 bhosale2 added invalid This doesn't seem right prio:medium Priority level: medium labels Jul 23, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 23, 2022
@bhosale2 bhosale2 self-assigned this Jul 23, 2022
@bhosale2 bhosale2 linked an issue Jul 23, 2022 that may be closed by this pull request
Inconsistent docstring for EndpointForces #154
Closed
@bhosale2 bhosale2 added the prio:high Priority level: high label Jul 23, 2022
armantekinalp
armantekinalp approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhosale2 bhosale2 removed the prio:medium Priority level: medium label Jul 23, 2022
@armantekinalp armantekinalp removed the request for review from skim0119 July 23, 2022 21:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #157 (24411f3) into update-0.3.0 (f3d3d73) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           update-0.3.0     #157   +/-   ##
=============================================
  Coverage         87.58%   87.58%           
=============================================
  Files                43       43           
  Lines              2780     2780           
  Branches            361      361           
=============================================
  Hits               2435     2435           
  Misses              326      326           
  Partials             19       19
Impacted Files Coverage Δ
elastica/external_forces.py 96.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d3d73...24411f3. Read the comment docs.

@bhosale2 bhosale2 merged commit 011a0fe into update-0.3.0 Jul 23, 2022
@bhosale2 bhosale2 deleted the 154_endpoint_forces_docstring_fix branch July 23, 2022 21:38
@bhosale2 bhosale2 mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@bhosale2 bhosale2

Labels
invalid This doesn't seem right prio:high Priority level: high
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.

Inconsistent docstring for EndpointForces
3 participants
@bhosale2 @codecov-commenter @armantekinalp