-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 3: Pytest for wrapper classes part 1 #262
Task 3: Pytest for wrapper classes part 1 #262
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #262 +/- ##
================================================
+ Coverage 93.87% 94.65% +0.78%
================================================
Files 43 43
Lines 2938 2938
Branches 341 341
================================================
+ Hits 2758 2781 +23
+ Misses 144 124 -20
+ Partials 36 33 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add one more test for two rods without collision
Sure thing! I will add that test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the test case for the wrapper class - ExternalContact as mentioned in #99
Because the codebase is not broken, all of the test cases are currently passing.