Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 3: Pytest for wrapper classes part 1 #262

Merged

Conversation

Rahul-JOON
Copy link
Contributor

This PR contains the test case for the wrapper class - ExternalContact as mentioned in #99

Because the codebase is not broken, all of the test cases are currently passing.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.78 🎉

Comparison is base (2e15d97) 93.87% compared to head (e4025b4) 94.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #262      +/-   ##
================================================
+ Coverage         93.87%   94.65%   +0.78%     
================================================
  Files                43       43              
  Lines              2938     2938              
  Branches            341      341              
================================================
+ Hits               2758     2781      +23     
+ Misses              144      124      -20     
+ Partials             36       33       -3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rahul-JOON Rahul-JOON marked this pull request as ready for review June 6, 2023 22:11
@Rahul-JOON Rahul-JOON changed the title WIP: Task 3: Pytest for wrapper classes part 1 Task 3: Pytest for wrapper classes part 1 Jun 6, 2023
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one more test for two rods without collision

tests/test_contact_wrapper_classes.py Outdated Show resolved Hide resolved
tests/test_contact_wrapper_classes.py Outdated Show resolved Hide resolved
tests/test_contact_wrapper_classes.py Outdated Show resolved Hide resolved
@Rahul-JOON
Copy link
Contributor Author

Sure thing! I will add that test.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit b40fdba into GazzolaLab:update-0.3.2 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants