Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitch for Genshin Impact on Apple Silicon #11

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

HongyuS
Copy link

@HongyuS HongyuS commented Mar 30, 2023

Without specifying the corresponding dxgi.customDeviceId and dxgi.customVendorId of the fake GPU model (AMD Radeon Pro 5300M) on Apple Silicon Mac, there may be some graphical glitches, especially in the desert region of Genshin.

Here is what the glitch may look like:
20230330173455

So I added dxgi.customDeviceId = 7340 and dxgi.customVendorId = 1002 to the config in this PR. It's tested on my M1 MacBook Air with 16GB of RAM.

@Gcenx
Copy link
Owner

Gcenx commented Mar 31, 2023

Could you provide an after screenshot showing the difference for reference?

@Gcenx Gcenx merged commit 8a2bab7 into Gcenx:1.10.x Mar 31, 2023
@HongyuS
Copy link
Author

HongyuS commented Mar 31, 2023

Could you provide an after screenshot showing the difference for reference?

Before patch:
截屏2023-03-31 23 12 34

After patch:
截屏2023-03-31 23 15 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants