Lua block comment totally broken

[hartman]

We updated MediaWiki to the latest version of Geshi last week, but now all Multiline comment blocks in the Lua language no longer close.

Examples:

• https://en.wikipedia.org/wiki/Module:String
• https://en.wikipedia.org/wiki/Module:Citation/CS1

[hartman]

Suspects are:
d55d075#diff-c1c00cfdab2a2a0fafc18e0edd552d99
f532384#diff-c1c00cfdab2a2a0fafc18e0edd552d99

@reedy i think we need to ping Marius :)

[anomiex]

More specifically, long-form comments are being matched greedily rather than non-greedily. The patch shown in f532384 seems to be the culprit in changing a .*? to .*.

[anomiex]

That same commit seems to have broken the highlighting of multi-line strings, which appears to have been abusing COMMENT_REGEXP in the absence of STRING_REGEXP.

[hartman]

I have a tested fix, will open pull request in a bit.

[Streusel]

@hartman Alignment issue and nothing points to the first index, only 2 and 3, intended?

edit: nvm, you fixed the alignment in a followup commit, but the first index isn't used.

[hartman]

@Streusel well, I mirrored how this was done for PHP. So 'COMMENT_SINGLE' => array(1 => "--") would be index 1.

I admit i didn't check if that is actually the correct or proper way to do it, but it seems to work for the php file.

[splitbrain]

This should be fixed with the merge of #63 and can be closed I believe.