Simplified syslog::unix() by using UnixDatagram::connect() (fixes #1)
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Geal did you have a chance to look at this PR? Anything wrong with it? |
|
It looks good, just let me find the time to test it. I was stuck with client work these past days, I might be able to look at it on Wednesday (or whenever I get bored of JS and do some Rust for distraction). |
|
@Geal, did you have a chance to test the pull request? |
Geal
added a commit
that referenced
this pull request
Aug 24, 2015
Simplified `syslog::unix()` by using `UnixDatagram::connect()` (fixes #1)
|
It's all good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing I'm not sure of, is whether next
connect()after error works for all platforms. I've tested only on linux.