Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar on side of itemlist component #1847

Closed
kaym0 opened this issue Apr 28, 2018 · 2 comments
Closed

Bar on side of itemlist component #1847

kaym0 opened this issue Apr 28, 2018 · 2 comments

Comments

@kaym0
Copy link

kaym0 commented Apr 28, 2018

All of the item lists have a bar on the side which indents them, but when making items into buttons (like in a drawer) it looks really stupid. Could you possibly add the option of taking this out? I understand that it works fine for the standard white design, but if you use any other design and want to highlight buttons like the current route it just looks super awkward having that bar there.

You can fix it using margins but it would be better if you could just not have an unneccessary indent there with another option. Like

<ListItem  noIntent> .... </ListItem>

Even the indent is fine if it's also styled by the listitem, because it would mean the awkward bar of none-listitem color wouldn't be there.

@kaym0
Copy link
Author

kaym0 commented Apr 28, 2018

Fix for this is to set items as itemDivider such as below

<ListItem itemDividier style={{backgroundColor: "#000000"}}>
....
</ListItem>

You can setup background color for each item and it spans the entire length of the actual list

akhil-ga added a commit that referenced this issue May 4, 2018
@SupriyaKalghatgi
Copy link
Contributor

Fixed with 2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants