Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Audio button doesn't stop audio for Play All/Stop, Loop All/Stop and Loop All/Stop (Reset) actions #59

Closed
mansman12 opened this issue Dec 9, 2021 · 2 comments
Assignees
Labels
🐞 bug Something might not be working as intended. 🔊 Stop Audio Issue relates to the "Stop Audio" action.
Milestone

Comments

@mansman12
Copy link

For actions like Play All/Stop, Loop All/Stop and Loop All/Stop (Reset), the Stop Audio button just moves on to the next track in the queue rather than ending the audio.

Is this intended functionality?

@mansman12 mansman12 changed the title Stop Audio button doesn't stop audio Stop Audio button doesn't stop audio for Play All/Stop, Loop All/Stop and Loop All/Stop (Reset) actions Dec 9, 2021
@GeekyEggo
Copy link
Owner

GeekyEggo commented Dec 19, 2021

@mansman12 I've tested this with the current release, and I'm able to replicate the problem you're encountering. This isn't how the stop audio action should be functioning, my apologies.

As part of #60 I've made some changes to stopping audio; would you mind testing a beta release (download link) to see if this fixes the problem for you please.

@GeekyEggo GeekyEggo self-assigned this Dec 19, 2021
@GeekyEggo GeekyEggo added the 🐞 bug Something might not be working as intended. label Dec 19, 2021
@GeekyEggo GeekyEggo added this to the vNext milestone Dec 19, 2021
@mansman12
Copy link
Author

@GeekyEggo I've tested the beta release and can confirm that the stop audio action now stops all audio from the play all and loop all actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something might not be working as intended. 🔊 Stop Audio Issue relates to the "Stop Audio" action.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants