Wrong address from equivalents derivation path #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q9f
approved these changes
Nov 11, 2022
|
|
||
| describe "m/-0" do | ||
| before do | ||
| @node = @master.node_for_path "m/-0" |
There was a problem hiding this comment.
I understand that m/0', m/0p, and m/-0 are all the same just different notations. Is there any specific reason you use the negative notation here?
There was a problem hiding this comment.
I am unable to see where I found the negative notation, probably my imagination....I will delete this code part
There was a problem hiding this comment.
Don't delete it. It's fine like this. It would be just more readable with the p notation
Suggested change
| @node = @master.node_for_path "m/-0" | |
| @node = @master.node_for_path "m/0p" |
There was a problem hiding this comment.
@node = @master.node_for_path "m/0p" is already present ( https://github.com/GemHQ/money-tree/pull/67/files#diff-a1ea91e56ff3d680c3d050616bda524a8b4eb8857c61b28304e319e290406725R222 ) .
Changes concerning rufo are done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #21