Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop c++03 #32

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Drop c++03 #32

merged 2 commits into from
Nov 11, 2016

Conversation

MarkusPrim
Copy link
Member

Remove c++03 as an option from the CMakeLists and drop the support. This also changes the version number to 2.1.0 to mark the break of backward compatibility.

@MarkusPrim
Copy link
Member Author

@Jojosito Any objections?

@Jojosito
Copy link
Contributor

I have no objections. Just to be on the safe side I would like to wait for an answer from panda. I don't know which c++ version they are using right now.

@ThomasHauth
Copy link
Contributor

Did you already contact someone from Panda about this question or can we add a Panda-Person to this PR?

@MarkusPrim
Copy link
Member Author

This PR is more symbolic, because we broke c++03 compatibility a bit earlier on the master branch. The C++03 compatibility was broken when we lost the boost dependency, because we used the c++11 pointer types to get rid of the boost equivalents (see commit 7d53e80) . When we decide to support c++03, we have to revert this too.

@MarkusPrim
Copy link
Member Author

Another comment: We can keep the ROOT5 compatibility with c++11, see PR #35

@Jojosito
Copy link
Contributor

I am in contact with the Panda software coordinator. He will address the issue in their meeting on monday. They are still using c++03, but are likely to switch.
Anyway, I guess we ca do the transition, and until panda does it as well, they will have to use some older genfit version which is still c++03.

@ThomasHauth
Copy link
Contributor

Thanks for checking back with the Panda colleagues, I will then merge this PR.

@ThomasHauth ThomasHauth merged commit fcc9dac into master Nov 11, 2016
@MarkusPrim MarkusPrim deleted the drop_c++03 branch November 11, 2016 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants