Handle int or str as section level value [CRITICAL] #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes critical bug described at <https://en.wikipedia.org/w/index.php?diff=1077793462&oldid=1077172445>. The API parse action is currently giving `level` as an int, rather than a string as it previously did; however, on pages from before this change it's still treated as a str. An abstract equality comparison seems like the most backward- and forward-compatible solution.
TamzinHadasa
changed the title
|
Ah ok, I see that block needs to be strict. Second commit handles that. On-wiki test. Successful result. This still fails but that's due to something beyond the scope of what I changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the critical bug described by @roysmith here. The API parse action is currently giving
levelas an int, rather than a string as it previously did; however, on pages from before this change it's still treated as a str. I've talked to a dev about this, and it's not yet clear whether this was an intended change, and, if it wasn't, whether it will be reverted. Given all of that, then, an abstract equality comparison seems like the most backward- and forward-compatible solution.Demo'd on-wiki, test successful